Skip to content

Add section: cdf of lebesgue stieltjes measure#1639

Merged
affeldt-aist merged 6 commits intomath-comp:masterfrom
Yosuke-Ito-345:cdf_lebesgue_stieltjes
Jul 3, 2025
Merged

Add section: cdf of lebesgue stieltjes measure#1639
affeldt-aist merged 6 commits intomath-comp:masterfrom
Yosuke-Ito-345:cdf_lebesgue_stieltjes

Conversation

@Yosuke-Ito-345
Copy link
Contributor

Motivation for this change

I add Section cdf_of_lebesgue_stieltjes_mesure in probability.v, which proves that the cumulative distribution function of a Lebesgue-Stieltjes measure goes back to the underlying function.

Checklist
  • added corresponding entries in CHANGELOG_UNRELEASED.md

  • added corresponding documentation in the headers

Reference: How to document

Merge policy

As a rule of thumb:

  • PRs with several commits that make sense individually and that
    all compile are preferentially merged into master.
  • PRs with disorganized commits are very likely to be squash-rebased.
Reminder to reviewers

@Yosuke-Ito-345
Copy link
Contributor Author

This error is strange.

Error: The variable truncn was not found in the current environment.

Why was truncn not found? I can certainly find truncn in archimedean.v.

@affeldt-aist
Copy link
Member

affeldt-aist commented Jun 5, 2025

This error is strange.

Error: The variable truncn was not found in the current environment.

Why was truncn not found? I can certainly find truncn in archimedean.v.

It might be because the CI is testing with the previous version of MathComp (2.3.0) in which there was no truncn.

@Yosuke-Ito-345
Copy link
Contributor Author

Thank you for the comment.
Then I think the pull request went well, but please tell me if I need to fix something.

@Yosuke-Ito-345
Copy link
Contributor Author

@affeldt-aist Would it be possible to review this pull request?

@affeldt-aist affeldt-aist added this to the 1.12.0 milestone Jul 1, 2025
@affeldt-aist affeldt-aist added the enhancement ✨ This issue/PR is about adding new features enhancing the library label Jul 1, 2025
@affeldt-aist affeldt-aist force-pushed the cdf_lebesgue_stieltjes branch from abd9408 to dff3bf7 Compare July 1, 2025 02:41
@affeldt-aist affeldt-aist self-requested a review July 1, 2025 03:17
Copy link
Member

@affeldt-aist affeldt-aist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is fine.
Maybe the declaration of lebesgue_stieltjes_measure as a probability measure should move to the file where the Lebesgue Stieltjes measure is defined, let's try before merging.

@affeldt-aist affeldt-aist force-pushed the cdf_lebesgue_stieltjes branch from dff3bf7 to 9d4b9ae Compare July 1, 2025 07:49
@affeldt-aist
Copy link
Member

I have introduced a tentative structure Cumulative01 that carries the proofs that the function tends to 0 in -oo and to 1 in +oo. This way we can put the HB declaration that the Lebesgue-Stieltjes measure of such a function is a probability measure in lebesgue_stieltjes_measure.v and cdf_lebesgue_stieltjes_id still type-checks. (fyi: @CohenCyril )

TODO: write documentation and changelog for Cumulative01 if deemed useful.

@Yosuke-Ito-345
Copy link
Contributor Author

@affeldt-aist
Thank you very much for the review.
I'd prefer to generalize 0 and 1, something like

HB.mixin Record isCumulativeBdd (R : numFieldType) (l u : R) (f : R -> R) := {
  cumulativeNyl : f @ -oo --> (l:R) ;
  cumulativeyu : f @ +oo --> (u:R) }.

#[short(type=cumulativeBdd)]
HB.structure Definition CumulativeBdd (R : numFieldType) (l u : R) :=
  { f of isCumulativeBdd R l u f & Cumulative R f}.

Arguments cumulativeNyl {R} l u s.
Arguments cumulativeyu {R} l u s.

Section probability_measure_of_lebesgue_stieltjes_mesure.
Context {R : realType} (f : @cumulativeBdd R 0 1).

But it's up to you, because 0 and 1 are sufficient for the time being.

@affeldt-aist affeldt-aist force-pushed the cdf_lebesgue_stieltjes branch from c91eb11 to 118d152 Compare July 2, 2025 13:32
@affeldt-aist
Copy link
Member

If think that it is ok to merge since the work will anyway continue with issue #1572 . @CohenCyril any thought?

@affeldt-aist affeldt-aist force-pushed the cdf_lebesgue_stieltjes branch from 118d152 to ac40f39 Compare July 3, 2025 06:45
@affeldt-aist affeldt-aist merged commit 45796d1 into math-comp:master Jul 3, 2025
34 checks passed
@Yosuke-Ito-345 Yosuke-Ito-345 deleted the cdf_lebesgue_stieltjes branch July 3, 2025 12:10
@Yosuke-Ito-345
Copy link
Contributor Author

Thank you for the review and the merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement ✨ This issue/PR is about adding new features enhancing the library

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants